Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Prettier CodeGen no checkstyle #778

Closed

Conversation

mickjermsurawong-stripe
Copy link
Contributor

@mickjermsurawong-stripe mickjermsurawong-stripe commented May 16, 2019

  • Code gen with prettier poet without going through code formatting script.
  • Currently tests fail because of checkstyle. Running the command locally will pass all existing test suite.
./gradlew build -x checkstyleMain

@mickjermsurawong-stripe mickjermsurawong-stripe force-pushed the mickjermsurawong/gen-no-checkstyle branch from c4d8fa3 to 1c95400 Compare May 19, 2019 21:57
@mickjermsurawong-stripe mickjermsurawong-stripe force-pushed the mickjermsurawong/gen-no-checkstyle branch from a85bdc6 to 18cafef Compare May 28, 2019 17:28
@mickjermsurawong-stripe mickjermsurawong-stripe force-pushed the mickjermsurawong/gen-no-checkstyle branch from 18cafef to fcd738c Compare June 9, 2019 02:53
@richardm-stripe richardm-stripe mentioned this pull request Aug 19, 2019
@ob-stripe
Copy link
Contributor

Closing in favor of #827.

@ob-stripe ob-stripe closed this Aug 20, 2019
@ob-stripe ob-stripe deleted the mickjermsurawong/gen-no-checkstyle branch August 20, 2019 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants