Prettier codegen

[richardm-stripe]

Result of https://github.com/stripe/stripe-api-codegen/pull/128

• uses prettier-poet
• supercedes [WIP] Prettier CodeGen no checkstyle #778, I guess

[richardm-stripe]

$ function dodiff { git diff origin/master --ignore-all-space | grep '^[+-]' | grep -v "^---" | grep -v "^+++"; }
$ function percent_diff { echo "scale=3; $(dodiff | $1 | wc -l)/$(dodiff | wc -l)" | bc -l; }
$ percent_diff 'grep String\.format'
.028
$ percent_diff 'grep Builder.params'
0
$ percent_diff 'grep public.*Builder'
.310
$ percent_diff 'grep \.request'
.016

[richardm-stripe]

I think most of this is method ordering still, though.

[richardm-stripe]

err, ordering of the embedded class definitions

[richardm-stripe]

Seems like the biggest offenders are the *Params.java files:

$ git show HEAD --stat=200 | tail +7 | awk '{ print $3 " "$4 " " $1}' | sort -n -r | less
1170 +++++++++++++------------------------------------------------------------------------------------------- src/main/java/com/stripe/param/issuing/CardCreateParams.java
1155 +++++++++++++----------------------------------------------------------------------------------------- src/main/java/com/stripe/param/issuing/CardholderCreateParams.java
1130 ++++++++++++---------------------------------------------------------------------------------------- src/main/java/com/stripe/param/issuing/CardholderUpdateParams.java
1066 +++++++++------------------------------------------------------------------------------------- src/main/java/com/stripe/param/issuing/CardUpdateParams.java
909 ++++++++++++++++++++++++++++++++++++++------------------------------------------- src/main/java/com/stripe/param/AccountCreateParams.java
893 +++++++++++++++++++++++++++++++++++++------------------------------------------ src/main/java/com/stripe/param/AccountUpdateParams.java
571 ++++++++++++++++++++++++--------------------------- src/main/java/com/stripe/param/SourceCreateParams.java
502 ++++++++++++++++++++------------------------- src/main/java/com/stripe/param/checkout/SessionCreateParams.java
463 ++++++++++++++++++++--------------------- src/main/java/com/stripe/param/SourceUpdateParams.java
415 ++++++++++++++++++------------------- src/main/java/com/stripe/param/SubscriptionScheduleUpdateParams.java
408 ++++++++++++++++++------------------ src/main/java/com/stripe/param/SubscriptionScheduleCreateParams.java
339 ++++++++++++++---------------- src/main/java/com/stripe/param/PersonCollectionCreateParams.java
325 +++++++++++++---------------- src/main/java/com/stripe/param/PersonUpdateParams.java
325 +++++++++++++---------------- src/main/java/com/stripe/param/CustomerCreateParams.java
312 +++++++++++++--------------- src/main/java/com/stripe/param/PaymentIntentCreateParams.java
288 +++----------------------- src/main/java/com/stripe/param/WebhookEndpointCreateParams.java

[richardm-stripe]

Ok, made the diff much smaller, adding some namespacing (and two whitespace changes which were most of the raw diff).

Biggest offenders now:

124 ++++++++++++++++++++++++++++++++++++++----------------------------------------------------------
--------- src/main/java/com/stripe/model/BankAccount.java
114 +++++++++++++++++++++++++----------------------------------------------------------------------- src/main/java/com/stripe/model/Invoice.java
112 +++++++++++++++++++++++++++++----------------------------------------------------------------- src/main/java/com/stripe/param/SubscriptionScheduleUpdateParams.java
100 ++++++++++++++++++++++++------------------------------------------------------------ src/main/java/com/stripe/param/SubscriptionScheduleCreateParams.java
97 ++++++++++++++++++++++++++++++++++++++++------------------------------------------ src/main/java/com/stripe/param/AccountCreateParams.java
95 +++++++++++++++++++++++++++++++++++++++----------------------------------------- src/main/java/com/stripe/param/AccountUpdateParams.java
85 +++++++++++++++++++++++++++++------------------------------------------- src/main/java/com/stripe/param/issuing/CardCreateParams.java
84 ++++++++++++++++------------------------------------------------------- src/main/java/com/stripe/model/Person.java
83 +++++++++++++++++++--------------------------------------------------- src/main/java/com/stripe/model/SubscriptionSchedule.java
82 +++++++++++---------------------------------------------------------- src/main/java/com/stripe/model/Charge.java
80 +++++++++++++++++--------------------------------------------------- src/main/java/com/stripe/model/PaymentIntent.java
72 +++++++++++++++++-------------------------------------------- src/main/java/com/stripe/model/Source.java
72 +++++++++++++++++++------------------------------------------ src/main/java/com/stripe/model/Account.java
71 ++++++++++++++++++++++++------------------------------------ src/main/java/com/stripe/param/issuing/CardholderCreateParams.java
71 ++++++++++++++++++++++++++++-------------------------------- src/main/java/com/stripe/param/SourceCreateParams.java
67 +++++++++++---------------------------------------------- src/main/java/com/stripe/model/TransferReversal.java
64 ++++++++---------------------------------------------- src/main/java/com/stripe/model/Dispute.jav

[richardm-stripe]

r? @ob-stripe
I think this is (finally) good to go.

[ob-stripe]

Here's the list of all changes I noticed:

ℹ️ = cosmetic change
⚠️ = functional change
🛑 = breaking

• ℹ️ No more // Generated by com.stripe.generator.entity.SdkBuilder header
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-50819d56df3bc1e819d28b74391998cdL1
• ℹ️ On model classes: interface order change, MetadataStore<X> now always comes first
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-50819d56df3bc1e819d28b74391998cdR24
• ℹ️ On model classes: when a field’s type is an inner class, use the fully qualified OuterClass.InnerClass name instead of just InnerClass
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-8bc69eecf526b1093a68dff194065d68R25
• ℹ️ On type adapter factory classes: some whitespace changes
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-6c2623fb084b0015a2df07f69ac4daa1L61
• ℹ️ On type adapter factory classes: small comment changes
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-6c2623fb084b0015a2df07f69ac4daa1R110-R111
• ℹ️ On model classes: method order change
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-7bf95a50f283d2b807d542d7a2c9d350R149
• ⚠️ On model classes for nested resources: removed the explicit check for null parent ID when creating the request URL
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-7bf95a50f283d2b807d542d7a2c9d350L415-L423
• 🛑 On model classes for collections: use request / requestCollection instead of ApiResource.request / ApiResource.requestCollection
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-355de6c5834c89029e1efcf2ac578fd5R19
• ℹ️ On model classes: use ApiResource.request instead of request
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-50819d56df3bc1e819d28b74391998cdR129
• ℹ️ On EventDataClassLookup: class order change, use fully qualified names for namespaced resources
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-e9f06146ff4b124110af64c7645efefeR80-R100
• ℹ️ On ApiResourceTypeAdapterFactoryProvider: factories are now in alphabetical order
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-f783315bca0a8e893d6ebd3731805044R18
• ℹ️ On parameter classes: whitespace change
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-98847ec806b9667e01cea5bde70b8221R11
• ℹ️ On parameter classes: use short name Builder instead of fully qualified name
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-98847ec806b9667e01cea5bde70b8221R31
• ℹ️ On parameter classes: removed a comment
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-98847ec806b9667e01cea5bde70b8221L40
• ℹ️ On parameter classes: use EnumParam instead of ApiRequest.EnumParam
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-d2dbcee8889246a1950a5f7294c99653R285

Most of these seem peaceful to me. Can I just ask you to fix these two?

• On parameter classes: whitespace change
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-98847ec806b9667e01cea5bde70b8221R11
• On parameter classes: removed a comment
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-98847ec806b9667e01cea5bde70b8221L40

ptal @richardm-stripe

[richardm-stripe]

ptal @ob-stripe
should be addressed with 430f00f

please also approve https://github.com/stripe/stripe-api-codegen/pull/129

[ob-stripe]

Looks great!

One final nit: can you fix the missing whitespace in adapter factory classes? Like here: https://github.com/stripe/stripe-java/pull/827/files#diff-c235a01258aeff703a67c9fd41deff9dL63

[richardm-stripe]

@ob-stripe done
d8beca3

[richardm-stripe]

@ob-stripe good to go now?

[ob-stripe]

LGTM!

Aside from the explicit null check in nested resources that was removed, all the other changes are noted are cosmetic and should have no impact on the output JAR.

Let's run the compatibility checker script to double check that the prettier version is 100% compatible with the current one, but I think this is ready to ship!

[ob-stripe]

Er, belay that, looks like tests are not passing.

[ob-stripe]

It's because of this change:

• 🛑 On model classes for collections: use request / requestCollection instead of ApiResource.request / ApiResource.requestCollection
  • Example: https://github.com/stripe/stripe-java/pull/827/files#diff-355de6c5834c89029e1efcf2ac578fd5R19

StripeCollection derives from StripeObject, not ApiResource, so it has to use the ApiResource.request/ApiResource.requestCollection forms to call these static methods.

ptal @richardm-stripe

[richardm-stripe]

There was one last change in b7b8e34

$ /tmp/compat/bin/japi-compliance-checker /tmp/old/stripe-java-11.6.1.jar /tmp/new/stripe-java-11.6.1.jar
Preparing, please wait ...
Using Java 1.8.0_212
Reading classes 11.6.1 ...
Reading classes 11.6.1 ...
Comparing classes ...
Creating compatibility report ...
Binary compatibility: 100%
Source compatibility: 100%
Total binary compatibility problems: 0, warnings: 0
Total source compatibility problems: 0, warnings: 0

[ob-stripe]

Released as 11.7.0 \o/