Remove deprecated configuration setter methods #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding a code snippet to the changelog message that illustrates the new way? |
pakrym-stripe
approved these changes
Nov 1, 2022
anniel-stripe
force-pushed
the
anniel-remove-deprecated
branch
from
a501fea
to
4468b74
Compare
| @@ -1023,8 +1023,6 @@ describe('StripeResource', () => { | |||
|
|
|||
| describe('Request Timeout', () => { | |||
| it('should allow the setting of a request timeout on a per-request basis', (done) => { | |||
| stripe.setTimeout(1000); | |||
There was a problem hiding this comment.
Why didn't this test start failing?
There was a problem hiding this comment.
This tests that the request is sent with a timeout of 10 when configured as a per-request option
anniel-stripe
force-pushed
the
anniel-remove-deprecated
branch
from
7567f54
to
cc03d44
Compare
pakrym-stripe
approved these changes
Nov 1, 2022
anniel-stripe
added a commit
that referenced
this pull request
Nov 16, 2022
* Update StripeSignatureVerificationError to accept header and payload strings * Build * Update supported runtime versions * Remove Orders and subscription_data[items] * Remove SKU resource * Remove SKUs.spec.js * Remove deprecated configuration setter methods (#1597) * Remove deprecated config properties * Update test and remove config properties from types/ * Remove setProtocol from types, refactor old tests * Replace more require('../lib/stripe') with Stripe * Remove global stripe from EphemeralKeys test * Rename local stripe to newStripe in stripe.spec.js * Refactor EphemeralKeys.spec.js * Remove more deprecated items (#1600) Remove remaining deprecated items * Generate files for next major (#1603) * Generate next major * Deprecate StripeResource.path and related interfaces (#1604) * Deprecate path * More fully deprecate * Fix linting errors * Revert "Fix linting errors" This reverts commit 68ac772. * Revert "Deprecate StripeResource.path and related interfaces (#1604)" This reverts commit 9c9de9e. * fix tests to work without Invoices defining fullPAth Co-authored-by: Richard Marmorstein <52928443+richardm-stripe@users.noreply.github.com> Co-authored-by: Richard Marmorstein <richardm@stripe.com> * Update LatestApiVersion and types reference * Update all references to latest API version * Regenerate * Latest API version * fix tests * Update API_VERSION and references * Format Co-authored-by: Richard Marmorstein <52928443+richardm-stripe@users.noreply.github.com> Co-authored-by: Richard Marmorstein <richardm@stripe.com> Co-authored-by: Pavel Krymets <pakrym@stripe.com> Co-authored-by: pakrym-stripe <99349468+pakrym-stripe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated configuration setter methods. Update tests that use these methods to set the corresponding property on the
configobject instead.Changelog
setHost,setProtocol,setPort,setApiVersion,setApiKey,setTimeout,setAppInfo,setHttpAgent,setMaxNetworkRetries, andsetTelemetryEnabled). Use the config object to set these options instead, for example: