-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next major release changes #1608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split StripeSignatureVerificationError detail field into header and payload
Update supported runtime versions
Generate files for next major branch
Remove SKU resource
Bring next major branch up to date with master
* Remove deprecated config properties * Update test and remove config properties from types/ * Remove setProtocol from types, refactor old tests * Replace more require('../lib/stripe') with Stripe * Remove global stripe from EphemeralKeys test * Rename local stripe to newStripe in stripe.spec.js * Refactor EphemeralKeys.spec.js
Bring next major branch up to date with master
Remove remaining deprecated items
* Generate next major * Deprecate StripeResource.path and related interfaces (#1604) * Deprecate path * More fully deprecate * Fix linting errors * Revert "Fix linting errors" This reverts commit 68ac772. * Revert "Deprecate StripeResource.path and related interfaces (#1604)" This reverts commit 9c9de9e. * fix tests to work without Invoices defining fullPAth Co-authored-by: Richard Marmorstein <52928443+richardm-stripe@users.noreply.github.com> Co-authored-by: Richard Marmorstein <richardm@stripe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good! My only suggestion is adding small blurb about what (if anything) users will need to change to handle the StripeSignatureVerificationError
changes
…iel-update-types-reference
Update sdk-release/next-major with latest changes
# Conflicts: # lib/StripeResource.js # src/StripeResource.ts # src/stripe.ts # src/utils.ts
…next-major Merge master to sdk-release/next-major
# Conflicts: # lib/StripeResource.js # src/StripeResource.ts
…aster_to_sdk-release_next-major Merge type changes from master to sdk release next major
…iel-latest-api-version
Update sdk-release/next-major with latest API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
11.0.0 - 2022-11-15
"⚠️ " symbol highlights breaking changes.
StripeSignatureVerificationError
to haveheader
andpayload
fields instead ofdetail
. To access these properties, useerr.header
anderr.payload
instead oferr.detail.header
anderr.detail.payload
. (Split StripeSignatureVerificationError detail field into header and payload #1574)Remove
Orders
resource. (Generate files for next major branch #1580)Remove
SKU
resource (Remove SKU resource #1583)Remove deprecated
CheckoutSessionCreateParams.subscription_data.items
. (Generate files for next major branch #1580)Remove deprecated configuration setter methods (
setHost
,setProtocol
,setPort
,setApiVersion
,setApiKey
,setTimeout
,setAppInfo
,setHttpAgent
,setMaxNetworkRetries
, andsetTelemetryEnabled
). (Remove deprecated configuration setter methods #1597)Use the config object to set these options instead, for example:
Remove deprecated basic method definitions. (Remove more deprecated items #1600)
Use basic methods defined on the resource instead.
Remove deprecated option names. Use the following option names instead (
OLD
->NEW
):api_key
->apiKey
,idempotency_key
->idempotencyKey
,stripe_account
->stripeAccount
,stripe_version
->apiVersion
,stripeVersion
->apiVersion
. (Remove more deprecated items #1600)Remove
charges
field onPaymentIntent
and replace it withlatest_charge
. (Update sdk-release/next-major with latest changes #1614 )Remove deprecated
amount
field onCheckout.Session.LineItem
. (Update sdk-release/next-major with latest changes #1614 )Remove support for
tos_shown_and_accepted
onCheckout.Session.PaymentMethodOptions.Paynow
. (Update sdk-release/next-major with latest changes #1614 )