Added typescript webhook example #749
Conversation
| res: express.Response, | ||
| next: express.NextFunction | ||
| ): void => { | ||
| if (req.originalUrl === '/webhooks') { |
There was a problem hiding this comment.
Is this our best-practice? Does line 55 not work here?
There was a problem hiding this comment.
Line 55 does work, but I've seen people get tripped up by how express' middleware works. Having this block here will hopefully nip that confusion in the bud (and makes it so all other routes use the json body parser).
|
|
||
| /* Strict Type-Checking Options */ | ||
| "strict": true /* Enable all strict type-checking options. */, | ||
| "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, |
There was a problem hiding this comment.
I don't think this is needed any longer
There was a problem hiding this comment.
It's needed for line 5 of express-ts.ts where we import dotenv.
| "compilerOptions": { | ||
| "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */, | ||
| "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, | ||
| "types": ["../../types/2019-12-03"], |
There was a problem hiding this comment.
This shouldn't be needed once it lands, but I guess we can keep it in till then?
There was a problem hiding this comment.
Yeah I wasn't sure if this is necessary or not, happy to remove once v8 lands.
| '/webhooks', | ||
| bodyParser.raw({type: 'application/json'}), | ||
| (req: express.Request, res: express.Response): express.Response | void => { | ||
| const sig: string = req.headers['stripe-signature'] as string; |
There was a problem hiding this comment.
this is fixed; you no longer need to cast!
r? @rattrayalex-stripe