Added typescript webhook example #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const app: express.Application = express(); | ||
|
|
||
| // Only use the raw body parser for webhooks. |
There was a problem hiding this comment.
I think we should remove this block, it implies that you need it, but I think you don't – the bodyParser.raw call is enough (worth double-checking, I'm not 100% sure
)
There was a problem hiding this comment.
I think this was specifically to showcase that for all other routes we want to use the json parser. See Paul's original comment on that: #749 (comment)
There was a problem hiding this comment.
Yeah... if we did this:
app.use(bodyParser.json());
app.post(
'/webhook',
bodyParser.raw({type: 'application/json'}),
(req: express.Request, res: express.Response): void => {would the app still work?
cc @adreyfus-stripe maybe you know?
rattrayalex-stripe
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
r? @rattrayalex-stripe
In Paul's absence, I'm looking to finish up the TypeScript webhook sample.