Update how veneur handles aws credentials. #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requestscc @stripe/observability |
* If aws creds are set in config file, try and load those up. * If no creds are set, follow the aws sdk golang loading order.
linuxdynasty
force-pushed
the
linuxdynasty/update_aws_credentials_loading
branch
from
170de2d to
785c9dc
Compare
|
@ChimeraCoder is the plugin system not going to be supported anymore or is this PR incomplete from your opinion and if so, what can I do to make it complete? |
…com:linuxdynasty/veneur into linuxdynasty-linuxdynasty/update_aws_credentials_loading
ChimeraCoder
approved these changes
Apr 21, 2020
|
Really sorry about the delay here. Yes, we do plan to continue supporting this plugin. Thanks for submitting this! |
yanke-stripe
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Update how veneur handles aws credentials. * If aws creds are set in config file, try and load those up. * If no creds are set, follow the aws sdk golang loading order. * golang→go Co-authored-by: Allen Sanabria <allen_sanabria@intuit.com> Co-authored-by: Aditya Mukerjee <dev@chimeracoder.net> Co-authored-by: Aditya Mukerjee <ChimeraCoder@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated server.go to use the aws sdk loading order (https://docs.aws.amazon.com/sdk-for-go/api/aws/session/) when the creds are not set in the config.yaml.
The only 2 options that are mandatory are.
stringstringThese parameters are optional.
stringstringThe Golang AWS SDK will load up Credentials in the following order. https://docs.aws.amazon.com/sdk-for-go/api/aws/session/
AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_SESSION_TOKEN,AWS_PROFILE,AWS_REGION~/.aws/credentialsexport AWS_SDK_LOAD_CONFIG=1Motivation
We are deploying Veneur and we do not want to hardcode aws credentials and we would rather use the iam role attached to the instance.
This change is