Change in Interval in the s3 plugin from int to float64 #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not passing Interval in server.go. Also in s3.go, interval was set to int instead
of float64.
Summary
As of right now any
samplers.CounterMetric
has a divide by 0 error which reports back as+Inf
. This PR will fix that error for the S3 Plugin and the Localfile plugin. I also updated the tests in csv_test.go and s3_tests.go to check for+Inf
.Motivation
Counters were producing
+Inf
Test plan
I updated tests in csv_test.go and s3_tests.go
Rollout/monitoring/revert plan
This change is