External VPC #34
Merged
External VPC #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsan92
added a commit
that referenced
this pull request
Aug 14, 2019
* Remove unnecessary interpolation for single quoted variables * Fmt 🤓 * Disable TFLint for now Ref: https://github.com/wata727/tflint#current-project-status * Fmt again 😃 * Fix `template_file` vars declarations * Update TF Docker image to official v0.12 🎉 * Update VPC module to v2.0.0 (TF 0.12 compatible) And fix some migration syntax * Enable TFLint again and set fixed Docker image version (0.8.0) * Remove terraform validate cmd due bug with -check-variables flag * Update TF version to v0.12 on tests files * Upgrade Terratest * fix: add workaround for buggy terraform validate cmd * chore: add explicit min version for aws provider TF 0.12 compatible * chore: add note about tf compatible version in readme * chore: rebasing #34 * chore: upgrade both tf and tflint dockerized binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the user to specify an already-created VPC to be used by the Fargate services. To activate this feature the user will need to provide the following variables:
vpc_createasfalse, this prevents the creation of the internal VPCvpc_external_idwhich is the unique id of the external VPC that must exist under the user's AWS accountvpc_external_public_subnets_ids/vpc_external_private_subnets_idsa list of ids for the public and private subnets, respectively.