Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 0.12 🚀 #26

Merged
merged 16 commits into from
Aug 14, 2019
Merged

Terraform 0.12 🚀 #26

merged 16 commits into from
Aug 14, 2019

Conversation

jlsan92
Copy link
Contributor

@jlsan92 jlsan92 commented Mar 21, 2019

This is the PR for the migration to Terraform 0.12. 🎉

So far will be marked as WIP since the 0.12 still in beta and most likely the CI will fail 🚨

Before merge ⚠️

Closes: #35

@jlsan92
Copy link
Contributor Author

jlsan92 commented May 26, 2019

Note: terraform validate disabled in CI because flag -check-variables flag seems to be removed from the command. I don't know if it's a bug or is intentionally removed, but in current docs the flag still there => https://www.terraform.io/docs/commands/validate.html#check-variables-true

Ref: hashicorp/terraform#21454

UPDATE: It seems that it's a bug in the cmd itself. Because terraform validate >= TF 0.12 has the -check-variables flag removed.

hashicorp/terraform#21408 (comment)

@jlsan92 jlsan92 merged commit 202cceb into master Aug 14, 2019
@jlsan92 jlsan92 deleted the terraform-0.12 branch August 14, 2019 08:39
@jlsan92 jlsan92 mentioned this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform 0.12 support ⭐️
1 participant