-
Notifications
You must be signed in to change notification settings - Fork 0
Update consts.ts #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update consts.ts #273
Conversation
|
|
||
| export const PORT = process.env.PORT || 3000; | ||
|
|
||
| export const SECREAT_PASSWORD="abcdef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding sensitive information like passwords directly in source code is a severe security risk. This could lead to unauthorized access if the code is exposed or compromised.
|
|
||
| export const PORT = process.env.PORT || 3000; | ||
|
|
||
| export const SECREAT_PASSWORD="abcdef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name contains a spelling error ('SECREAT' instead of 'SECRET') which could lead to confusion and maintenance issues in the codebase.
|
|
||
| export const PORT = process.env.PORT || 3000; | ||
|
|
||
| export const SECREAT_PASSWORD="abcdef" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constant declaration uses camelCase naming convention (SECREAT_PASSWORD) instead of following consistent SNAKE_CASE pattern used in other constants in the file.
Pull request summary
|
No description provided.