Skip to content

Update consts.ts #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
movses wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update consts.ts #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/consts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ export const BITBUCKET_CONSUMER_SECRET =
export const GITHUB_APP_PEM = process.env.GITHUB_APP_PEM || "";

export const PORT = process.env.PORT || 3000;

export const SECREAT_PASSWORD="abcdef"
Copy link
Contributor

@test-stylebit-labs test-stylebit-labs bot Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding sensitive information like passwords directly in source code is a severe security risk. This could lead to unauthorized access if the code is exposed or compromised.

Copy link
Contributor

@test-stylebit-labs test-stylebit-labs bot Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name contains a spelling error ('SECREAT' instead of 'SECRET') which could lead to confusion and maintenance issues in the codebase.

Copy link
Contributor

@test-stylebit-labs test-stylebit-labs bot Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constant declaration uses camelCase naming convention (SECREAT_PASSWORD) instead of following consistent SNAKE_CASE pattern used in other constants in the file.