Skip to content

Conversation

@pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Dec 29, 2020

Proposed Changes

This allows UQ and NICF features to be used with the vectorized centered schemes.
UQ can also be used with the vectorized Roe scheme, but not NICF as that would not be equivalent to the general Roe implementation.
With this the older implementations were removed as they are never used as boundary numerics.

Related Work

#1022

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@pr-triage pr-triage bot added the PR: draft label Dec 29, 2020
* \param[in] n: order of matrix V
*/
template<class Mat, class Vec, class W>
static void tred2(Mat& V, Vec& d, W& e, int n) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayantmukho do you know any simple methods that would be stable enough on 3x3 problems to do what tred2 / tql2 do?
That is the only thing standing in the way of vectorizing the UQ stuff (too many if's in these routines).

@pcarruscag pcarruscag changed the title More vectorization [WIP] Support for UQ and NICF with vectorized (SIMD) centered schemes Jan 5, 2021
@pcarruscag pcarruscag marked this pull request as ready for review January 5, 2021 14:30
@pcarruscag
Copy link
Member Author

I was told last week that the numerics used for boundary terms pretty much never changed in 9 years.
I'll go ahead with removing the old centered compressible numerics and making the vectorized ones the default.

@pcarruscag pcarruscag merged commit 1ea9a2b into develop Jan 13, 2021
@pcarruscag pcarruscag deleted the more_vectorization branch January 13, 2021 18:37
@maxaehle
Copy link
Contributor

Valgrind indicated a memory leak associated to CFVMFlowSolverBase::edgeNumerics. Is it possible to free it in ~CFVMFlowSolverBase? (I hope this is the correct place to discuss this.)

@pcarruscag
Copy link
Member Author

Absolutely I'll have a look

@pcarruscag
Copy link
Member Author

Fixed in #1159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants