-
Notifications
You must be signed in to change notification settings - Fork 915
Support for UQ and NICF with vectorized (SIMD) centered schemes #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * \param[in] n: order of matrix V | ||
| */ | ||
| template<class Mat, class Vec, class W> | ||
| static void tred2(Mat& V, Vec& d, W& e, int n) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayantmukho do you know any simple methods that would be stable enough on 3x3 problems to do what tred2 / tql2 do?
That is the only thing standing in the way of vectorizing the UQ stuff (too many if's in these routines).
|
I was told last week that the numerics used for boundary terms pretty much never changed in 9 years. |
|
Valgrind indicated a memory leak associated to |
|
Absolutely I'll have a look |
|
Fixed in #1159 |
Proposed Changes
This allows UQ and NICF features to be used with the vectorized centered schemes.
UQ can also be used with the vectorized Roe scheme, but not NICF as that would not be equivalent to the general Roe implementation.
With this the older implementations were removed as they are never used as boundary numerics.
Related Work
#1022
PR Checklist