Skip to content

Support for UQ and NICF with vectorized (SIMD) centered schemes #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcarruscag merged 14 commits into from
Jan 13, 2021
Merged

Support for UQ and NICF with vectorized (SIMD) centered schemes #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e8ed1ea
move eigen stuff to blas structure
pcarruscag Dec 29, 2020
6feaef2
delete some unused stuff
pcarruscag Dec 29, 2020
cec349a
more cleaning
pcarruscag Dec 29, 2020
3842409
further simplification
pcarruscag Jan 1, 2021
20cebb7
fix AD build and a bug in AddQCR
pcarruscag Jan 1, 2021
264d2e0
allow UQ + vectorization
pcarruscag Jan 2, 2021
b0e6db1
all features supported with vectorized centered schemes
pcarruscag Jan 4, 2021
34b4ef6
update regressions
pcarruscag Jan 5, 2021
08f8bcb
remove old centered schemes
pcarruscag Jan 5, 2021
bc3f801
body of CEulerSolver::CenteredResidual no longer needed
pcarruscag Jan 5, 2021
f81b457
Merge remote-tracking branch 'upstream/develop' into more_vectorization
pcarruscag Jan 5, 2021
89d9a2c
update filediffs
pcarruscag Jan 5, 2021
4d2d293
Merge branch 'develop' into more_vectorization
pcarruscag Jan 13, 2021
518754a
fix mem leak, fix gcc 4.8
pcarruscag Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Common/include/grid_movement/CFreeFormDefBox.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,13 +756,4 @@ class CFreeFormDefBox : public CGridMovement {
*/
inline unsigned short GetLevel() const { return Level; }

/*!
* \brief Compute the determinant of a 3 by 3 matrix.
* \param[in] val_matrix 3 by 3 matrix.
* \result Determinant of the matrix
*/
inline su2double Determinant_3x3(su2double A00, su2double A01, su2double A02, su2double A10, su2double A11, su2double A12, su2double A20, su2double A21, su2double A22) {
return A00*(A11*A22-A12*A21) - A01*(A10*A22-A12*A20) + A02*(A10*A21-A11*A20);
}

};
20 changes: 0 additions & 20 deletions Common/include/grid_movement/CVolumetricMovement.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,26 +361,6 @@ class CVolumetricMovement : public CGridMovement {
*/
void UpdateGridCoord_Derivatives(CGeometry *geometry, CConfig *config);

/*!
* \brief Compute the determinant of a 3 by 3 matrix.
* 3 by 3 matrix elements
* \param[in] A00
* \param[in] A01
* \param[in] A02
* \param[in] A10
* \param[in] A11
* \param[in] A12
* \param[in] A20
* \param[in] A21
* \param[in] A22
* \result Determinant of the matrix
*/
inline su2double Determinant_3x3(su2double A00, su2double A01, su2double A02, su2double A10, su2double A11, su2double A12, su2double A20, su2double A21, su2double A22) {
return A00*(A11*A22-A12*A21) - A01*(A10*A22-A12*A20) + A02*(A10*A21-A11*A20);
}



/*!
* \brief Store the number of iterations when moving the mesh.
* \param[in] val_nIterMesh - Number of iterations.
Expand Down
6 changes: 3 additions & 3 deletions Common/include/linear_algebra/CSysVector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
unsigned long nElm = 0; /*!< \brief Total number of elements (or number elements on this processor). */
unsigned long nElmDomain = 0; /*!< \brief Total number of elements without Ghost cells. */
unsigned long nVar = 0; /*!< \brief Number of elements in a block. */
mutable ScalarType dotRes = 0.0; /*!< \brief Result of dot product. to perform a reduction with OpenMP the
variable needs to be declared outside the parallel region. */

/*!
* \brief Generic initialization from a scalar or array.
Expand Down Expand Up @@ -101,7 +99,7 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
/*!
* \brief Default constructor of the class.
*/
CSysVector() {}
CSysVector() = default;

/*!
* \brief Destructor
Expand Down Expand Up @@ -291,8 +289,10 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
*/
template <class T>
ScalarType dot(const VecExpr::CVecExpr<T, ScalarType>& expr) const {
static ScalarType dotRes;
/*--- All threads get the same "view" of the vectors and shared variable. ---*/
SU2_OMP_BARRIER
SU2_OMP_MASTER
dotRes = 0.0;
SU2_OMP_BARRIER

Expand Down
Loading