Addition of Source Terms for NEMO Axisymmetric Flows #1162
Conversation
…mulation Signed-off-by: jtneedels <jneedels@stanford.edu>
…es up to eliminate compiler warnings Signed-off-by: jtneedels <jneedels@stanford.edu>
jtneedels
changed the title
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
@jtneedels thanks for deriving these source terms. They will be very helpful!
Please find my comments above
| su2double u = V_i[VEL_INDEX]; | ||
| su2double v = V_i[VEL_INDEX+1]; | ||
|
|
||
| qy_ve = kve*GV[TVE_INDEX][1]; |
There was a problem hiding this comment.
you could do something similar here: "su2double qy_ve"
Again, this just aesthetic
| } | ||
| } | ||
|
|
||
| auto residual = numerics->ComputeAxisymmetric(config); |
There was a problem hiding this comment.
Something is off with your spacings here
| Res_TruncError.resize(nPoint,nVar) = su2double(0.0); | ||
|
|
||
| /*--- Size Grad_AuxVar for axiysmmetric ---*/ | ||
|
|
… term, addressed PR comments (spacing, initialization) Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
WallyMaier
left a comment
WallyMaier
left a comment
There was a problem hiding this comment.
This looks good to me! I think you should wait for another approval before pushing.
|
@jtneedels the testcases currently failing are my fault, they will be fixed in a minute. |
CatarinaGarbacz
left a comment
CatarinaGarbacz
left a comment
There was a problem hiding this comment.
Hi @jtneedels . good work. I just made some minor comments, I didn't notice anything "big", so for me it's a GO
| residual[nSpecies+3] = yinv*rhov*U_i[nSpecies+nDim+1]/rho*Volume; | ||
|
|
||
| if (viscous) { | ||
|
|
| for (iSpecies = 0; iSpecies < nHeavy; iSpecies++) { | ||
| sumJhs_y += (rho*Ds[iSpecies]*GV[RHOS_INDEX+iSpecies][1] - V_i[RHOS_INDEX+iSpecies]*Vector[1]) * hs[iSpecies]; | ||
| sumJeve_y += (rho*Ds[iSpecies]*GV[RHOS_INDEX+iSpecies][1] - V_i[RHOS_INDEX+iSpecies]*Vector[1]) * eve_i[iSpecies]; | ||
| } |
There was a problem hiding this comment.
you can just ident this 2 lines for aesthetics (the += part)
There was a problem hiding this comment.
I would not spend too much time with that kind of alignment, eventually we will run clang-format on the entire code... The only thing you can do to make code look good is to write small functions.
| eAxi_local++; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
extra line between between the brackets
There was a problem hiding this comment.
Thanks Catarina, I think I've addressed this and the other comments on formatting.
Signed-off-by: jtneedels <jneedels@stanford.edu>
…/SU2 into feature_nemo_axi_viscous
Signed-off-by: jtneedels <jneedels@stanford.edu>
Proposed Changes
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.