Skip to content

Conversation

@jtneedels
Copy link
Contributor

Proposed Changes

  • This PR addresses an issue I found in my previous implementation where the chemistry source residual was being computed incorrectly when the axisymmetric source residual was called.
  • This implementation fixes that issue, caused by using outer and inner loops.
  • This PR eliminates redundant set functions, and restructures the code blocks to minimize the number of loops.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Signed-off-by: jtneedels <jneedels@stanford.edu>
Signed-off-by: jtneedels <jneedels@stanford.edu>
@pr-triage pr-triage bot added the PR: draft label Jan 18, 2021
@jtneedels jtneedels marked this pull request as ready for review January 19, 2021 00:14
@jtneedels jtneedels requested a review from WallyMaier January 19, 2021 07:35
Copy link
Contributor

@WallyMaier WallyMaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtneedels thanks for the quick fix of this problem! I think it would be nice to include some results, but otherwise, it looks good to me!

/*--- Set solution ---*/
numerics->SetConservative(nodes->GetSolution(iPoint), nodes->GetSolution(iPoint));

/*--- Set control volume ---*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice not having to recompute these.

Signed-off-by: jtneedels <jneedels@stanford.edu>
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a fix let's merge it for the release (later today).

@pcarruscag pcarruscag merged commit 916a99d into develop Jan 20, 2021
@pcarruscag pcarruscag deleted the feature_nemo_axi_comp branch January 20, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants