Sub-config files for multizone problems #715
Conversation
…to feature_mz_config
| STEADY_TRANSLATION = 11, /*!< \brief Simulation in a steadily translating frame. */ | ||
| GUST = 12, /*!< \brief Simulation on a static mesh with a gust. */ | ||
| MOVING_HTP = 13, /*!< \brief Simulation with moving HTP (rotation). */ | ||
| FLUID_STRUCTURE_STATIC = 14 /*!< \brief Fluid structure deformation with no grid velocity. */ |
There was a problem hiding this comment.
Should the identifiers be updated?
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks @talbring, very welcome refactoring.
Please see my two comments below.
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks for the changes I asked.
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
LGTM. Last chance if anyone has some final comments, otherwise we'll merge shortly.
|
Was playing around with the turbomachinery cases with the new multi-zone config. I like the new changes, makes it much clearer! Just a remark, don't know if this is on purpose, but for the configuration parameter TURBOMACHINERY_KIND, you still need to supply them in the general configuration file for both zones (so in case of a two zone problem: TURBOMACHINERY_KIND = CENTRIFUGAL CENTRIFUGAL). Wouldnt it make more sense to have this per zone specified in the respective configuration file? |
talbring
changed the title
Proposed Changes
This is the first part of a series of PRs which completely refactor the output (and parts of the input).
In this one I introduce the sub-config file feature for multizone/multiphysics problems. More information on how it works can be found here:
https://su2code.github.io/docs/Multizone
Note that the automatic deduction of the correct interface type is not working at the moment. So the
MARKER_FLUID_INTERFACEorMARKER_CHT_INTERFACEstill has to be there at the moment ...Furthermore this changes the way grid movement is specified in the config files. Examples can be found also using the link above or by simply looking at the
sliding_interfacetest cases.Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.