This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Smooth out block editor loading state #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll use this to present the editor when it is fully ready.
No sense in making this excessively complicated. Just use async/await to get what we need in one effect. Along the way, made changes an array so we can compose update functions.
bfollington
reviewed
Dec 21, 2023
Comment on lines
+122
to
+133
| case loadRelated | ||
| case succeedLoadRelated(_ related: [EntryStub]) | ||
| case failLoadRelated(_ error: String) | ||
| /// Load transcludes into cache for entire document | ||
| case loadTranscludes | ||
| case succeedLoadTranscludes([EntryStub]) | ||
| case loadTranscludesFor(id: UUID, slashlinks: [Slashlink]) | ||
| case succeedLoadTranscludesFor( | ||
| id: UUID, | ||
| fetched: [EntryStub] | ||
| transcludes: [EntryStub] | ||
| ) | ||
| case failFetchTranscludesFor(id: UUID, error: String) | ||
| case failLoadTranscludesFor(id: UUID, error: String) |
There was a problem hiding this comment.
Very nice! This is exactly the flexibility I think we need to minimise perceived load time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043