Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Smooth out block editor loading state #1045

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Smooth out block editor loading state #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6764c68
Stub in basic animation for editor
gordonbrander Dec 20, 2023
b51f7e5
Move load related to setEditor
gordonbrander Dec 20, 2023
2e99af4
Make naming of actions consistent
gordonbrander Dec 20, 2023
9287d92
Load everything for block editor in one effect
gordonbrander Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions xcode/Subconscious/Shared/UIKit/BlockEditor/Appendix/Related/BlockEditorRelatedModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import Foundation

extension BlockEditor {
/// A collection of related notes
struct RelatedModel: Hashable, Identifiable {
var id = UUID()
struct RelatedModel: Hashable {
/// Is related loading?
var loadingState = LoadingState.loading
var related: [EntryStub] = []
}
}
Expand Down
3 changes: 0 additions & 3 deletions xcode/Subconscious/Shared/UIKit/BlockEditor/Appendix/Related/RelatedCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
{
static let identifier = "RelatedCell"

var id: UUID = UUID()

var send: (RelatedAction) -> Void = { _ in }

private var relatedHostingView = UIHostingView<BacklinksView>()
Expand Down Expand Up @@ -76,7 +74,6 @@
parentController: UIViewController,
state: BlockEditor.RelatedModel
) {
self.id = state.id
relatedHostingView.update(
parentController: parentController,
rootView: BacklinksView(
Expand All @@ -102,7 +99,7 @@
EntryStub(
did: Did("did:key:abc123")!,
address: Slashlink("@example/foo")!,
excerpt: Subtext(markup: "An [[autopoietic system]] is a network of processes that recursively depend on each other for their own generation and realization."),

Check warning on line 102 in xcode/Subconscious/Shared/UIKit/BlockEditor/Appendix/Related/RelatedCell.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Line Length Violation: Line should be 100 characters or less; currently it has 188 characters (line_length)
isTruncated: true,
modified: Date.now
),
Expand Down
Loading
Loading