Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript with JSX and ES7 decorators #1236

Closed
wants to merge 1 commit into from

Conversation

Kronuz
Copy link

@Kronuz Kronuz commented Oct 17, 2017

This adds basic JSX and ES7 decorators to the JavaScript

This adds basic JSX and ES7 decorators to the JavaScript
@rwols
Copy link
Contributor

rwols commented Oct 17, 2017

This will most definitely result in a merge conflict if #1009 gets merged, perhaps branch off of that and see where you land?

@FichteFoll
Copy link
Collaborator

I'm also not sure whether it was decided to have jsx be a separate syntax or to include it in the Javascript syntax. See the separate issue for details.

@Thom1729
Copy link
Collaborator

Thom1729 commented Nov 9, 2017

#1009 is merged, and it does look as though the changes conflict. If it helps, I intend to implement decorators as part of #1269 within the next few weeks. (I'm waiting on #1292 to lessen the risk of conflicts, but that's a much smaller change than #1009 was.)

Per #860, the current plan is to add a separate JSX syntax. There are some unanswered questions about the details of maintaining two syntaxes like that. In any case, it would probably be best to finish up #1292 first.

@michaelblyons
Copy link
Collaborator

Is this obsolete, now that #1483 is merged?

@Thom1729
Copy link
Collaborator

Thom1729 commented May 7, 2018

It is.

@Thom1729
Copy link
Collaborator

Now that #1483 is merged, this should be closed.

@wbond wbond closed this Feb 8, 2019
@wbond
Copy link
Member

wbond commented Feb 8, 2019

Decorators are now part of JavaScript, and if we include support for JSX, it will be a separate syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants