[JavaScript] Implemented decorators. #1483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1236.
Implements the decorators proposal, resolving #1477. The proposal is just shy of our usual standard of adoption: it's Stage 2 and expected to advance, and a conformant implementation is expected for Babel 7 (though a nonconformant implementation has existed for years). For historical reasons, there's a fair bit of code out there using decorators anyway, and because the feature is on the standards track I think it's reasonable to add it.
The proposed syntax is not completely finalized, but it is a virtual certainty that it will be a subset of this implementation (based on the
LeftExpression
production). Radical change is extremely unlikely at this point.Currently, decorators are the sole major core ECMAScript feature supported by Babel-sublime but absent from the core syntax. JS Custom offers an implementation, though it's lower-quality than this one. It is likely that Babel-sublime will be "rebased" off the core syntax some time after the next stable release, and core decorator support would be an asset to that change.