-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial implementation #1
Conversation
def required_node_version(cls) -> str: | ||
return '>=20' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work with v18?
We are currently including 18 with lsp_utils so it would be quite inconvenient if it wouldn't work with that.
(that said, it's probably a good time to update to 20 in lsp_utils)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m following what is defined in language server package.json
engines field: https://github.com/wkillerud/some-sass/blob/main/packages/language-server/package.json#L14
I suppose it could work with Node 18, I know I’ve used it before I switched to Node 20.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's time to update node version in lsp_utils I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing in sublimelsp/lsp_utils#125.
We should release those at the same time (or lsp_utils first).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve update PR description to reflect this.
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
There is a custom command that the server triggers from code actions after selecting some text: https://github.com/wkillerud/some-sass/blob/0623e9162d70fd526f87b5185459801c9e481b67/vscode-extension/src/client.ts#L170-L234 This would need to be implemented manually in here. |
Oh, haven’t seen this one. Is there any previous work in other LSP plugins on how to implement those custom commands? |
Existing examples: https://github.com/search?q=org%3Asublimelsp%20on_pre_server_command&type=code |
As per sublimelsp/repository#120 (comment), this PR adds initial implementation for language server.
Waiting on: