Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node to 20.18.0 #125

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: update node to 20.18.0 #125

merged 3 commits into from
Oct 24, 2024

Conversation

rchl
Copy link
Member

@rchl rchl commented Oct 19, 2024

Update to latest stable Node version.

Latest Electron version is based on Node 20.18.0 which is currently matched latest Node stable version - https://releases.electronjs.org/

@jfcherng
Copy link
Contributor

jfcherng commented Oct 19, 2024

One thing you may or may not care is that it will causes the Node.js not to run on some old machines, which uses glibc < 2.18 (Electron) or 2.25 (Node.js). And that's why I have https://github.com/jfcherng-sublime/ST-my-settings/blob/d89ba4b65be583506a30c1b5b3f3b846a2fa9a6d/Packages/my_plugin_38/0_lsp_utils.py#L30-L61 because some machines I work on the company are old (e.g., CentOS 7).

This PR won't affect me anyway but just a fyi.

@rchl
Copy link
Member Author

rchl commented Oct 19, 2024

One thing you may or may not care is that it will causes the Node.js won't run on some old machines, which uses glibc <= 2.17. And that's why I have jfcherng-sublime/ST-my-settings@b4b2b10/Packages/my_plugin_38/0_lsp_utils.py#L24-L38 because some machines I work on the company are old (e.g., CentOS 7).

This PR won't affect me anyway but just a fyi.

I think I'd prefer more consistent environment that consistently doesn't work rather than dynamic like that that then causes some servers to not work.

@rchl rchl merged commit f4a5ccb into main Oct 24, 2024
3 checks passed
@rchl rchl deleted the fix/update-node branch October 24, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants