Ask for confirmation before disabling OpenShift CVO #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr222/skitt/confirm-cvo-disabling |
skitt
force-pushed
the
confirm-cvo-disabling
branch
from
432b948 to
fc7091b
Compare
|
🤖 Updated branch: z_pr222/skitt/confirm-cvo-disabling |
skitt
force-pushed
the
confirm-cvo-disabling
branch
from
fc7091b to
a0ae575
Compare
|
🤖 Updated branch: z_pr222/skitt/confirm-cvo-disabling |
When subctl join is run against an OpenShift cluster with a deployed cluster version operator, and service discovery is enabled, we now ask for confirmation before continuing, because installing service discovery will disable the CVO. Fixes: submariner-io#167 Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
confirm-cvo-disabling
branch
from
a0ae575 to
f3997bb
Compare
|
🤖 Updated branch: z_pr222/skitt/confirm-cvo-disabling |
aswinsuryan
approved these changes
Mar 3, 2020
vthapar
approved these changes
Mar 4, 2020
|
🤖 Closed branches: [z_pr222/skitt/confirm-cvo-disabling] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subctl join is run against an OpenShift cluster with a deployed
cluster version operator, and service discovery is enabled, we now ask
for confirmation before continuing, because installing service
discovery will disable the CVO.
Fixes: #167
Signed-off-by: Stephen Kitt skitt@redhat.com