Allow halting (and restarting) pods on certificate errors #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2854/skitt/halt-on-certificate-error |
skitt
force-pushed
the
halt-on-certificate-error
branch
from
1a27fa3 to
d938202
Compare
skitt
added
the
backport
tpantelis
approved these changes
Oct 24, 2023
skitt
force-pushed
the
halt-on-certificate-error
branch
from
d938202 to
2277453
Compare
General practice in Kubernetes is to restart pods relying on certificates when those certificates are changed. Because Kubernetes isn't aware of cross-cluster certificate changes, this doesn't happen automatically when the broker certificate (or trust chain) changes; this produces certificate errors and ultimately results in a broken setup. To avoid this, provide a setting to set up gateway and Lighthouse agent pods to halt on certificate errors. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
halt-on-certificate-error
branch
from
2277453 to
bcfc312
Compare
sridhargaddam
approved these changes
Oct 25, 2023
dfarrell07
approved these changes
Oct 25, 2023
|
🤖 Closed branches: [z_pr2854/skitt/halt-on-certificate-error] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General practice in Kubernetes is to restart pods relying on certificates when those certificates are changed. Because Kubernetes isn't aware of cross-cluster certificate changes, this doesn't happen automatically when the broker certificate (or trust chain) changes; this produces certificate errors and ultimately results in a broken setup.
To avoid this, provide a setting to set up gateway and Lighthouse agent pods to halt on certificate errors.
See submariner-io/submariner#2761 and submariner-io/lighthouse#1408.