Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Invite users #111

Closed
AntoLC opened this issue Jul 1, 2024 · 0 comments · Fixed by #140
Closed

♻️Invite users #111

AntoLC opened this issue Jul 1, 2024 · 0 comments · Fixed by #140
Assignees
Labels
enhancement New feature or request frontend

Comments

@AntoLC
Copy link
Collaborator

AntoLC commented Jul 1, 2024

Feature Request

For the moment we have a 2 buttons (Add members / Manage Members), each one open is own modal, we want to refactorize this part to mutualize them in 1 modal, with a different design.

Before

image
image

After

image
image

Goal step

  • On the top of the modal add the logic of "Add members", the roles will be in a select box.
  • Under we will list the users added, so we need to import the logic of "Manage Members", and adapt it to the new design
    • We will use a infinite scroll to display the users
    • We will add a trash icon on the right of the user to remove them
    • Preserve the roles update information

Code resources

Add member:
https://github.com/numerique-gouv/impress/blob/main/src/frontend/apps/impress/src/features/docs/members/members-add/components/ModalAddMembers.tsx
Manage Members:
https://github.com/numerique-gouv/impress/blob/main/src/frontend/apps/impress/src/features/docs/members/members-grid/components/MemberGrid.tsx
InfiniteScroll:
https://github.com/numerique-gouv/impress/blob/main/src/frontend/apps/impress/src/components/InfiniteScroll.tsx

@AntoLC AntoLC self-assigned this Jul 1, 2024
@AntoLC AntoLC linked a pull request Jul 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant