Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) add user from side modal #140

Merged
merged 3 commits into from
Jul 12, 2024
Merged

♻️(frontend) add user from side modal #140

merged 3 commits into from
Jul 12, 2024

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Jul 10, 2024

Purpose

We move the member functionalities to a side modal.
The side modal is opened from the share button.

Demo

scrnli_7_11_2024_2-23-45.PM.webm

@AntoLC AntoLC added enhancement New feature or request frontend labels Jul 10, 2024
@AntoLC AntoLC self-assigned this Jul 10, 2024
@AntoLC AntoLC linked an issue Jul 10, 2024 that may be closed by this pull request
@AntoLC AntoLC force-pushed the refacto/share-modal branch 3 times, most recently from 3cde5d9 to a88d4ca Compare July 12, 2024 11:25
AntoLC added 3 commits July 12, 2024 13:27
We move the add user functionality to a side modal.
The side modal is opened from the share button.
Create IconBG component, a premade Icon component
with a background color.
We refactorize the members grid to display
it inside the share side modal.
It is not a member grid anymore but a member list
with infinite scroll. We can directly update the
role or delete a member from the each row of the
list.
@AntoLC AntoLC force-pushed the refacto/share-modal branch from a88d4ca to a20ecac Compare July 12, 2024 13:00
@AntoLC AntoLC marked this pull request as ready for review July 12, 2024 13:41
@AntoLC AntoLC merged commit 69f2641 into main Jul 12, 2024
16 checks passed
@AntoLC AntoLC deleted the refacto/share-modal branch July 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️Invite users
1 participant