Render digital bookplate information when present #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @param [String] image_id | ||
| # @param [Symbol] size | ||
| # @return [String] | ||
| def craft_image_url(druid, image_id, size) |
There was a problem hiding this comment.
We should update this to use IIIF sometime. If you visit the generated urls, it'll redirect you to the IIIF equivalents.
There was a problem hiding this comment.
Yeah, probably. Just curious, would the correct thing be here (for the 400px long-edge) to construct the druid + image id + /full/!400,400/0/default.jpg for this kind of thing? Or is there another url pattern we should be using?
There was a problem hiding this comment.
👍 good call. I've made that change.
jkeck
force-pushed
the
1062-bookplates
branch
from
baf375b
to
a4547c3
Compare
jkeck
force-pushed
the
1062-bookplates
branch
from
a4547c3
to
d57c6cf
Compare
aeschylus
added a commit
that referenced
this pull request
Nov 4, 2015
Render digital bookplate information when present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1062
There will probably be some styling updates that we'll want to make. Since we don't have a live index we can't deploy this anywhere, but @jvine I'm more than happy to show you what it looks like in different screen resolutions, etc using the fixture data.
@aeschylus Please leave any comments w/ questions you have about these changes. We can also discuss over chat or in person next week depending on your availability.
Record View
Search Results