Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Government documents access point and featured resource block #1080

Merged
merged 6 commits into from
Nov 4, 2015

Conversation

jkeck
Copy link
Contributor

@jkeck jkeck commented Oct 30, 2015

(requires #1074)

Home Page

feature-block

### Search Results

masthead

Note: There is a config option which sets the block on the home page off by default. This will allow us to ship this code to production whenever we want and turn it on once the data is present.

<div>
<p>Stanford is a depository library for state, federal, UN, and EU government documents.</p>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get real language before merging this, or is there a ticket to make sure we do this before deploying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably. The link to it on the home page is "off" by default so if we did push this to prod there would be no way to get here to see this text.

@jvine do you have text in mind for this? I could also just kill the <p> and add it later if needed (although it looks a little silly w/o it).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkeck I don't have text yet. If you haven't already removed it, maybe leave the lorem ipsum in place for now.

aeschylus added a commit that referenced this pull request Nov 4, 2015
Add Government documents access point and featured resource block
@aeschylus aeschylus merged commit 05bed55 into master Nov 4, 2015
@jkeck jkeck deleted the gov-docs-access-point branch November 4, 2015 03:11
@jvine jvine added this to the 3.1 milestone Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants