Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new column for file_language in the file_manifest.csv #1379

Closed
andrewjbtw opened this issue Nov 2, 2023 · 1 comment · Fixed by #1382
Closed

Support new column for file_language in the file_manifest.csv #1379

andrewjbtw opened this issue Nov 2, 2023 · 1 comment · Fixed by #1382
Assignees
@mjgiarlo

Comments

@andrewjbtw
Copy link

We've added a language field to the Cocina file model, initially as a way to support captioning work. This will allow us to show users which language a particular file uses. See sul-dlss/cocina-models#640

This ticket should be done after sul-dlss/argo#4258 which is for making this field user-editable in Argo. The spreadsheet used in Preassembly needs to match the form of the Argo spreadsheet, so we should make sure Argo is settled first.

The proposal is to add the field as a new column in the file_manifest.csv. It should be called file_language and it should be optional.
@jcoyne
Copy link
Contributor

jcoyne commented Nov 6, 2023

Blocked by sul-dlss/argo#4258

@mjgiarlo mjgiarlo self-assigned this Nov 8, 2023
@mjgiarlo mjgiarlo mentioned this issue Nov 8, 2023
Merged
2 tasks
mjgiarlo added a commit that referenced this issue Nov 8, 2023
@mjgiarlo
Add file language to the manifest (upload spreadsheet)
dbf9950 
Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.
mjgiarlo added a commit that referenced this issue Nov 10, 2023
@mjgiarlo
Add file language to the manifest (upload spreadsheet)
a48d486 
Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.
mjgiarlo added a commit that referenced this issue Nov 10, 2023
@mjgiarlo
Add file language to the manifest (upload spreadsheet)
5d4d5e6 
Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.
mjgiarlo added a commit that referenced this issue Nov 13, 2023
@mjgiarlo
Add file language to the manifest (upload spreadsheet)
4389cab 
Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjgiarlo mjgiarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add file language to the manifest (upload spreadsheet) sul-dlss/pre-assembly
3 participants
@jcoyne @mjgiarlo @andrewjbtw