Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file language to the manifest (upload spreadsheet) #1382

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

mjgiarlo
Copy link
Member

@mjgiarlo mjgiarlo commented Nov 8, 2023

Why was this change made?

Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.

How was this change tested?

  • CI
  • QA/stage

@mjgiarlo mjgiarlo force-pushed the file-language-column#1379 branch 2 times, most recently from a48d486 to 5d4d5e6 Compare November 10, 2023 20:13
@mjgiarlo mjgiarlo changed the title Add file language to the manifest (upload spreadsheet) [HOLD] Add file language to the manifest (upload spreadsheet) Nov 10, 2023
@mjgiarlo mjgiarlo marked this pull request as ready for review November 10, 2023 23:30
Fixes #1379

This commit brings pre-assembly's upload spreadsheet into parity with Argo, and allows users to specify what language a file is in (using a BCP47 code). This is needed to express the language of caption files for media.
This is needed for the media enhancement work cycle
@mjgiarlo mjgiarlo force-pushed the file-language-column#1379 branch from b4e6c8e to 9d04d53 Compare November 13, 2023 17:39
@mjgiarlo mjgiarlo changed the title [HOLD] Add file language to the manifest (upload spreadsheet) Add file language to the manifest (upload spreadsheet) Nov 13, 2023
@mjgiarlo mjgiarlo merged commit abf9b09 into main Nov 13, 2023
@mjgiarlo mjgiarlo deleted the file-language-column#1379 branch November 13, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new column for file_language in the file_manifest.csv
2 participants