Fix: email change improvements #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
commented
Jul 30, 2021
Comment on lines
+139
to
+155
| go func(e, t string) { | ||
| data := map[string]interface{}{ | ||
| "SiteURL": m.Config.SiteURL, | ||
| "ConfirmationURL": url, | ||
| "Email": user.GetEmail(), | ||
| "NewEmail": user.EmailChange, | ||
| "Token": t, | ||
| "Data": user.UserMetaData, | ||
| } | ||
| errors <- m.Mailer.Mail( | ||
| e, | ||
| string(withDefault(m.Config.Mailer.Subjects.EmailChange, "Confirm Email Change")), | ||
| m.Config.Mailer.Templates.EmailChange, | ||
| defaultEmailChangeMail, | ||
| data, | ||
| ) | ||
| }(email, token) |
There was a problem hiding this comment.
Send emails concurrently via goroutines since they don't have to be sequential
kangmingtay
commented
Jul 30, 2021
Comment on lines
+158
to
+165
| for i := 0; i < len(tokens); i++ { | ||
| e := <-errors | ||
| if e != nil { | ||
| return e | ||
| } | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
check if any of the goroutines experienced an error sending the email
thebengeu
approved these changes
Aug 2, 2021
models/user.go
Outdated
| @@ -341,6 +352,11 @@ func FindUserByRecoveryToken(tx *storage.Connection, token string) (*User, error | |||
| return findUser(tx, "recovery_token = ?", token) | |||
| } | |||
|
|
|||
| // FindUserByRecoveryToken finds a user with the matching recovery token. | |||
|
|
||
| DO $$ | ||
| BEGIN | ||
| IF NOT EXISTS(SELECT * |
There was a problem hiding this comment.
ah yeah you're right, i forgot to remove my docker volume after making the change manually so i thought the migration worked 😅
| THEN | ||
| ALTER TABLE "auth"."users" RENAME COLUMN "email_change_token" TO "email_change_token_new"; | ||
| END IF; | ||
| END $$; |
There was a problem hiding this comment.
Nit: add newline at end of file?
|
🎉 This PR is included in version 2.0.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Fix: email change improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Addresses #60 and #78
What is the current behavior?
Email change verification is broken.
What is the new behavior?
Allows a user to change their email. Requires the user's jwt access token to call
PUT /user.For security reasons, we send out 2 emails when a user makes an update email request:
The user needs to log into both email accounts and verify by clicking both links.
Design
email_change_token_current: Keeps track of token sent to current emailemail_change_token_new: Keeps track of token sent to new emailemail_change_confirm_status: Keeps track of the number of verified email (0, 1, 2)Additional context
Adds
/verify?type=email_changeto handle email change verification logic.