Feature/email change improvements #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awalias check it please=) |
kangmingtay
reviewed
Jun 28, 2021
There was a problem hiding this comment.
Hi @icecream78, thanks so much for working on this! Sorry for the delay in the review, we were really busy with other issues in the pipeline. This PR looks mostly good to me except for the url being sent in the email change confirmation email. We need to make sure it points to the /verify endpoint to complete the change email flow.
Comment on lines
+268
to
+270
| if params.Token != user.EmailChangeToken { | ||
| return unauthorizedError("Email Change Token didn't match token on file") | ||
| } |
There was a problem hiding this comment.
We don't have to do this check here because we already do a models.FindUserByEmailChangeToken in line 252. If the token is invalid (doesn't match the email change token), then line 252 would return a models.IsNotFoundError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #60 I've implemented logic for verification email changing.
Previous logic for email change verification was moved to common GET /verify handler that now can handle new type of requests - email_change.