Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update openapi spec for MFA (Phone) #1689

Merged
merged 4 commits into from
Aug 1, 2024
Merged

fix: update openapi spec for MFA (Phone) #1689

merged 4 commits into from
Aug 1, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jul 29, 2024 •
edited
Loading

What kind of change does this PR introduce?

Complement to #1668

Add OpenAPI specification for MFA (Phone). In particular, updates the parameters and /enroll /challenge and /verify

@J0 J0 changed the title fix: update openapi spec fix: update openapi spec for MFA (Phone) Jul 29, 2024
@coveralls
Copy link

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10187105858

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 259 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 58.221%
Files with Coverage Reduction New Missed Lines %
internal/api/token.go 19 72.37%
internal/models/factor.go 21 79.71%
internal/conf/configuration.go 94 71.58%
internal/api/mfa.go 125 62.85%
Totals Coverage Status
Change from base Build 10151130647: -0.02%
Covered Lines: 9171
Relevant Lines: 15752
💛 - Coveralls

@J0 J0 changed the title fix: update openapi spec for MFA (Phone) fix: update openapi spec for MFA (Phone) and add admin methods Jul 30, 2024
@J0 J0 changed the title fix: update openapi spec for MFA (Phone) and add admin methods fix: update openapi spec for MFA (Phone) Jul 31, 2024
@J0
Copy link
Contributor Author

J0 commented Jul 31, 2024

Opted defer the update of the admin methods to later, until rollout is completed, so that folks cannot accidentally update their Factor to become a Phone factor or create a phone factor unless the feature flag is explicitly enabled.

@J0 J0 marked this pull request as ready for review July 31, 2024 20:19
@J0 J0 requested a review from a team as a code owner July 31, 2024 20:19
J0
J0 commented Jul 31, 2024
View reviewed changes
openapi.yaml Show resolved Hide resolved
@J0 J0 merged commit a3da4b8 into master Aug 1, 2024
2 checks passed
@J0 J0 deleted the j0/add_mfa_phone_openapi_spec branch August 1, 2024 05:32
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Merged
J0 pushed a commit that referenced this pull request Aug 5, 2024
@github-actions
chore(master): release 2.158.1 (#1699)
499f6fc 
🤖 I have created a release *beep* *boop*
---


##
[2.158.1](v2.158.0...v2.158.1)
(2024-08-05)


### Bug Fixes

* add last_challenged_at field to mfa factors
([#1705](#1705))
([29cbeb7](29cbeb7))
* allow enabling sms hook without setting up sms provider
([#1704](#1704))
([575e88a](575e88a))
* drop the MFA_ENABLED config
([#1701](#1701))
([078c3a8](078c3a8))
* enforce uniqueness on verified phone numbers
([#1693](#1693))
([70446cc](70446cc))
* expose `X-Supabase-Api-Version` header in CORS
([#1612](#1612))
([6ccd814](6ccd814))
* include factor_id in query
([#1702](#1702))
([ac14e82](ac14e82))
* move is owned by check to load factor
([#1703](#1703))
([701a779](701a779))
* refactor TOTP MFA into separate methods
([#1698](#1698))
([250d92f](250d92f))
* remove check for content-length
([#1700](#1700))
([81b332d](81b332d))
* remove FindFactorsByUser
([#1707](#1707))
([af8e2dd](af8e2dd))
* update openapi spec for MFA (Phone)
([#1689](#1689))
([a3da4b8](a3da4b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@J0
fix: update openapi spec for MFA (Phone) (supabase#1689)
6d3041d 
## What kind of change does this PR introduce?

Complement to supabase#1668 

Add OpenAPI specification for MFA (Phone). In particular, updates the
parameters and `/enroll` `/challenge` and `/verify`
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.158.1 (supabase#1699)
a3655af 
🤖 I have created a release *beep* *boop*
---


##
[2.158.1](supabase/auth@v2.158.0...v2.158.1)
(2024-08-05)


### Bug Fixes

* add last_challenged_at field to mfa factors
([supabase#1705](supabase#1705))
([29cbeb7](supabase@29cbeb7))
* allow enabling sms hook without setting up sms provider
([supabase#1704](supabase#1704))
([575e88a](supabase@575e88a))
* drop the MFA_ENABLED config
([supabase#1701](supabase#1701))
([078c3a8](supabase@078c3a8))
* enforce uniqueness on verified phone numbers
([supabase#1693](supabase#1693))
([70446cc](supabase@70446cc))
* expose `X-Supabase-Api-Version` header in CORS
([supabase#1612](supabase#1612))
([6ccd814](supabase@6ccd814))
* include factor_id in query
([supabase#1702](supabase#1702))
([ac14e82](supabase@ac14e82))
* move is owned by check to load factor
([supabase#1703](supabase#1703))
([701a779](supabase@701a779))
* refactor TOTP MFA into separate methods
([supabase#1698](supabase#1698))
([250d92f](supabase@250d92f))
* remove check for content-length
([supabase#1700](supabase#1700))
([81b332d](supabase@81b332d))
* remove FindFactorsByUser
([supabase#1707](supabase#1707))
([af8e2dd](supabase@af8e2dd))
* update openapi spec for MFA (Phone)
([supabase#1689](supabase#1689))
([a3da4b8](supabase@a3da4b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@J0 @LashaJini
fix: update openapi spec for MFA (Phone) (supabase#1689)
79d444e 
## What kind of change does this PR introduce?

Complement to supabase#1668 

Add OpenAPI specification for MFA (Phone). In particular, updates the
parameters and `/enroll` `/challenge` and `/verify`
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.158.1 (supabase#1699)
8583c12 
🤖 I have created a release *beep* *boop*
---


##
[2.158.1](supabase/auth@v2.158.0...v2.158.1)
(2024-08-05)


### Bug Fixes

* add last_challenged_at field to mfa factors
([supabase#1705](supabase#1705))
([29cbeb7](supabase@29cbeb7))
* allow enabling sms hook without setting up sms provider
([supabase#1704](supabase#1704))
([575e88a](supabase@575e88a))
* drop the MFA_ENABLED config
([supabase#1701](supabase#1701))
([078c3a8](supabase@078c3a8))
* enforce uniqueness on verified phone numbers
([supabase#1693](supabase#1693))
([70446cc](supabase@70446cc))
* expose `X-Supabase-Api-Version` header in CORS
([supabase#1612](supabase#1612))
([6ccd814](supabase@6ccd814))
* include factor_id in query
([supabase#1702](supabase#1702))
([ac14e82](supabase@ac14e82))
* move is owned by check to load factor
([supabase#1703](supabase#1703))
([701a779](supabase@701a779))
* refactor TOTP MFA into separate methods
([supabase#1698](supabase#1698))
([250d92f](supabase@250d92f))
* remove check for content-length
([supabase#1700](supabase#1700))
([81b332d](supabase@81b332d))
* remove FindFactorsByUser
([supabase#1707](supabase#1707))
([af8e2dd](supabase@af8e2dd))
* update openapi spec for MFA (Phone)
([supabase#1689](supabase#1689))
([a3da4b8](supabase@a3da4b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@J0 @LashaJini
fix: update openapi spec for MFA (Phone) (supabase#1689)
a6a38a9 
## What kind of change does this PR introduce?

Complement to supabase#1668 

Add OpenAPI specification for MFA (Phone). In particular, updates the
parameters and `/enroll` `/challenge` and `/verify`
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.158.1 (supabase#1699)
dad9be7 
🤖 I have created a release *beep* *boop*
---


##
[2.158.1](supabase/auth@v2.158.0...v2.158.1)
(2024-08-05)


### Bug Fixes

* add last_challenged_at field to mfa factors
([supabase#1705](supabase#1705))
([29cbeb7](supabase@29cbeb7))
* allow enabling sms hook without setting up sms provider
([supabase#1704](supabase#1704))
([575e88a](supabase@575e88a))
* drop the MFA_ENABLED config
([supabase#1701](supabase#1701))
([078c3a8](supabase@078c3a8))
* enforce uniqueness on verified phone numbers
([supabase#1693](supabase#1693))
([70446cc](supabase@70446cc))
* expose `X-Supabase-Api-Version` header in CORS
([supabase#1612](supabase#1612))
([6ccd814](supabase@6ccd814))
* include factor_id in query
([supabase#1702](supabase#1702))
([ac14e82](supabase@ac14e82))
* move is owned by check to load factor
([supabase#1703](supabase#1703))
([701a779](supabase@701a779))
* refactor TOTP MFA into separate methods
([supabase#1698](supabase#1698))
([250d92f](supabase@250d92f))
* remove check for content-length
([supabase#1700](supabase#1700))
([81b332d](supabase@81b332d))
* remove FindFactorsByUser
([supabase#1707](supabase#1707))
([af8e2dd](supabase@af8e2dd))
* update openapi spec for MFA (Phone)
([supabase#1689](supabase#1689))
([a3da4b8](supabase@a3da4b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J0 @coveralls @kangmingtay