fix: include factor_id in query #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Aug 2, 2024
Pull Request Test Coverage Report for Build 10220108127Details
💛 - Coveralls |
J0
pushed a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.158.1](v2.158.0...v2.158.1) (2024-08-05) ### Bug Fixes * add last_challenged_at field to mfa factors ([#1705](#1705)) ([29cbeb7](29cbeb7)) * allow enabling sms hook without setting up sms provider ([#1704](#1704)) ([575e88a](575e88a)) * drop the MFA_ENABLED config ([#1701](#1701)) ([078c3a8](078c3a8)) * enforce uniqueness on verified phone numbers ([#1693](#1693)) ([70446cc](70446cc)) * expose `X-Supabase-Api-Version` header in CORS ([#1612](#1612)) ([6ccd814](6ccd814)) * include factor_id in query ([#1702](#1702)) ([ac14e82](ac14e82)) * move is owned by check to load factor ([#1703](#1703)) ([701a779](701a779)) * refactor TOTP MFA into separate methods ([#1698](#1698)) ([250d92f](250d92f)) * remove check for content-length ([#1700](#1700)) ([81b332d](81b332d)) * remove FindFactorsByUser ([#1707](#1707)) ([af8e2dd](af8e2dd)) * update openapi spec for MFA (Phone) ([#1689](#1689)) ([a3da4b8](a3da4b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * `FixLatestUnexpiredChallenge` should be scoped to the `factor_id` and not all challenges in the table ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.158.1](supabase/auth@v2.158.0...v2.158.1) (2024-08-05) ### Bug Fixes * add last_challenged_at field to mfa factors ([supabase#1705](supabase#1705)) ([29cbeb7](supabase@29cbeb7)) * allow enabling sms hook without setting up sms provider ([supabase#1704](supabase#1704)) ([575e88a](supabase@575e88a)) * drop the MFA_ENABLED config ([supabase#1701](supabase#1701)) ([078c3a8](supabase@078c3a8)) * enforce uniqueness on verified phone numbers ([supabase#1693](supabase#1693)) ([70446cc](supabase@70446cc)) * expose `X-Supabase-Api-Version` header in CORS ([supabase#1612](supabase#1612)) ([6ccd814](supabase@6ccd814)) * include factor_id in query ([supabase#1702](supabase#1702)) ([ac14e82](supabase@ac14e82)) * move is owned by check to load factor ([supabase#1703](supabase#1703)) ([701a779](supabase@701a779)) * refactor TOTP MFA into separate methods ([supabase#1698](supabase#1698)) ([250d92f](supabase@250d92f)) * remove check for content-length ([supabase#1700](supabase#1700)) ([81b332d](supabase@81b332d)) * remove FindFactorsByUser ([supabase#1707](supabase#1707)) ([af8e2dd](supabase@af8e2dd)) * update openapi spec for MFA (Phone) ([supabase#1689](supabase#1689)) ([a3da4b8](supabase@a3da4b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * `FixLatestUnexpiredChallenge` should be scoped to the `factor_id` and not all challenges in the table ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.158.1](supabase/auth@v2.158.0...v2.158.1) (2024-08-05) ### Bug Fixes * add last_challenged_at field to mfa factors ([supabase#1705](supabase#1705)) ([29cbeb7](supabase@29cbeb7)) * allow enabling sms hook without setting up sms provider ([supabase#1704](supabase#1704)) ([575e88a](supabase@575e88a)) * drop the MFA_ENABLED config ([supabase#1701](supabase#1701)) ([078c3a8](supabase@078c3a8)) * enforce uniqueness on verified phone numbers ([supabase#1693](supabase#1693)) ([70446cc](supabase@70446cc)) * expose `X-Supabase-Api-Version` header in CORS ([supabase#1612](supabase#1612)) ([6ccd814](supabase@6ccd814)) * include factor_id in query ([supabase#1702](supabase#1702)) ([ac14e82](supabase@ac14e82)) * move is owned by check to load factor ([supabase#1703](supabase#1703)) ([701a779](supabase@701a779)) * refactor TOTP MFA into separate methods ([supabase#1698](supabase#1698)) ([250d92f](supabase@250d92f)) * remove check for content-length ([supabase#1700](supabase#1700)) ([81b332d](supabase@81b332d)) * remove FindFactorsByUser ([supabase#1707](supabase#1707)) ([af8e2dd](supabase@af8e2dd)) * update openapi spec for MFA (Phone) ([supabase#1689](supabase#1689)) ([a3da4b8](supabase@a3da4b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * `FixLatestUnexpiredChallenge` should be scoped to the `factor_id` and not all challenges in the table ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.158.1](supabase/auth@v2.158.0...v2.158.1) (2024-08-05) ### Bug Fixes * add last_challenged_at field to mfa factors ([supabase#1705](supabase#1705)) ([29cbeb7](supabase@29cbeb7)) * allow enabling sms hook without setting up sms provider ([supabase#1704](supabase#1704)) ([575e88a](supabase@575e88a)) * drop the MFA_ENABLED config ([supabase#1701](supabase#1701)) ([078c3a8](supabase@078c3a8)) * enforce uniqueness on verified phone numbers ([supabase#1693](supabase#1693)) ([70446cc](supabase@70446cc)) * expose `X-Supabase-Api-Version` header in CORS ([supabase#1612](supabase#1612)) ([6ccd814](supabase@6ccd814)) * include factor_id in query ([supabase#1702](supabase#1702)) ([ac14e82](supabase@ac14e82)) * move is owned by check to load factor ([supabase#1703](supabase#1703)) ([701a779](supabase@701a779)) * refactor TOTP MFA into separate methods ([supabase#1698](supabase#1698)) ([250d92f](supabase@250d92f)) * remove check for content-length ([supabase#1700](supabase#1700)) ([81b332d](supabase@81b332d)) * remove FindFactorsByUser ([supabase#1707](supabase#1707)) ([af8e2dd](supabase@af8e2dd)) * update openapi spec for MFA (Phone) ([supabase#1689](supabase#1689)) ([a3da4b8](supabase@a3da4b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
FixLatestUnexpiredChallengeshould be scoped to thefactor_idand not all challenges in the tableWhat is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.