-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sanitize_params to correctly resolve nested columns #222
Conversation
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.51%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov ReportBase: 91.37% // Head: 91.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 91.37% 91.51% +0.14%
==========================================
Files 23 24 +1
Lines 1148 1167 +19
==========================================
+ Hits 1049 1068 +19
Misses 99 99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@J0 let me know if there's anything else to do here! 😄 |
@guillego, Thanks for your patience - nothing on your end for now. I'll review it tomorrow and hopefully we can get a release out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks so much for this!
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Nested columns (of the form
foreign_table.column
) are currently escaped which breaks the API exposed by postgrest.#189
#202
What is the new behavior?
This PR modifies the sanitize_parameters() function so that the
.
character is not escaped anymore.It also adds some test to verify this behavior.