Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanitize_params to correctly resolve nested columns (Sourcery refactored) #223

Closed
wants to merge 5 commits into from

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Feb 21, 2023

Pull Request #222 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/supabase-community/postgrest-py pull/222/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Feb 21, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.52%.

Quality metrics Before After Change
Complexity 0.07 ⭐ 0.06 ⭐ -0.01 👍
Method Length 25.32 ⭐ 26.47 ⭐ 1.15 👎
Working memory 3.16 ⭐ 3.33 ⭐ 0.17 👎
Quality 96.25% 95.73% -0.52% 👎
Other metrics Before After Change
Lines 134 168 34
Changed files Quality Before Quality After Quality Change
postgrest/utils.py 95.25% ⭐ 95.25% ⭐ 0.00%
tests/_async/test_filter_request_builder.py 96.38% ⭐ 95.78% ⭐ -0.60% 👎
tests/_sync/test_filter_request_builder.py 96.38% ⭐ 95.78% ⭐ -0.60% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 91.37% // Head: 91.51% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (34dca79) compared to base (ea579fd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   91.37%   91.51%   +0.14%     
==========================================
  Files          23       24       +1     
  Lines        1148     1167      +19     
==========================================
+ Hits         1049     1068      +19     
  Misses         99       99              
Impacted Files Coverage Δ
postgrest/utils.py 93.33% <100.00%> (ø)
tests/_async/test_filter_request_builder.py 100.00% <100.00%> (ø)
tests/_sync/test_filter_request_builder.py 100.00% <100.00%> (ø)
tests/test_utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sourcery-ai sourcery-ai bot closed this Feb 25, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/pull-222 branch February 25, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant