Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch type on remove #143

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix: patch type on remove #143

merged 3 commits into from
Sep 15, 2023

Conversation

J0
Copy link
Collaborator

@J0 J0 commented Sep 15, 2023

What kind of change does this PR introduce?

Address #83 and run unasync.

Semver changes from #142 should probably go in first

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bf90db3) 85.38% compared to head (14be266) 85.38%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files          12       12           
  Lines         431      431           
=======================================
  Hits          368      368           
  Misses         63       63           
Files Changed Coverage Δ
storage3/_async/file_api.py 84.48% <100.00%> (ø)
storage3/_sync/file_api.py 84.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 merged commit 8dbd29a into main Sep 15, 2023
@J0 J0 deleted the j0/patch_remove_type branch September 15, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants