Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch type on remove #143

Merged
merged 3 commits into from
Sep 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,36 @@ jobs:

- name: Upload Coverage
uses: codecov/codecov-action@v1

publish:
needs: test
if: ${{ !startsWith(github.event.head_commit.message, 'bump:') && github.ref == 'refs/heads/main' && github.event_name == 'push' }}
if: ${{ !startsWith(github.event.head_commit.message, 'bump') && !startsWith(github.event.head_commit.message, 'chore') && github.ref == 'refs/heads/master' && github.event_name == 'push' && github.repository_owner == 'supabase-community' }}
runs-on: ubuntu-latest
name: "Bump version, create changelog and publish"
environment:
name: pypi
url: https://pypi.org/p/storage3
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
contents: write # needed for github actions bot to write to repo
steps:
- name: Clone Repository
uses: actions/checkout@v2
with:
ref: ${{ github.ref }}
fetch-depth: 0
- name: Python Semantic Release
id: release
uses: python-semantic-release/python-semantic-release@v8.0.0
with:
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Publish package distributions to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
# NOTE: DO NOT wrap the conditional in ${{ }} as it will always evaluate to true.
# See https://github.com/actions/runner/issues/1173
if: steps.release.outputs.released == 'true'

- name: Python Semantic Release
uses: relekang/python-semantic-release@master
uses: python-semantic-release/upload-to-gh-release@master
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
repository_username: __token__
repository_password: ${{ secrets.PYPI_TOKEN }}
2 changes: 1 addition & 1 deletion storage3/_async/file_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ async def copy(self, from_path: str, to_path: str) -> dict[str, str]:
)
return res.json()

async def remove(self, paths: list) -> dict[str, str]:
async def remove(self, paths: list) -> list[dict[str, any]]:
"""
Deletes files within the same bucket

Expand Down
2 changes: 1 addition & 1 deletion storage3/_sync/file_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def copy(self, from_path: str, to_path: str) -> dict[str, str]:
)
return res.json()

def remove(self, paths: list) -> dict[str, str]:
def remove(self, paths: list) -> list[dict[str, any]]:
"""
Deletes files within the same bucket

Expand Down