fix(storage): use backward compatible return type in download function #1750
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Update
BlobDownloadBuilder
to be fully compatible with the Promise interface to maintain backward compatibility.What changed?
BlobDownloadBuilder
now implements the entire Promise interface so it can be assigned to a Promise variable without TypeScript complaining.Why was this change needed?
This resolves a breaking type change introduced in storage-js
2.12.2
by this PR: supabase/storage-js#137Currently, assigning the return of the
download()
function to a strongly typed variable results in a type error:Additionally, attempting to use
.catch()
or.finally()
would result in an error as those functions were not defined inBlobDownloadBuilder
so anyone depending on them would hit a runtime error.📸 Screenshots/Examples