Skip to content

fix(storage): use backward compatible return type in download function #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

fix(storage): use backward compatible return type in download function #1750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions packages/core/storage-js/src/packages/BlobDownloadBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ import { isStorageError } from '../lib/errors'
import { DownloadResult } from '../lib/types'
import StreamDownloadBuilder from './StreamDownloadBuilder'

export default class BlobDownloadBuilder implements PromiseLike<DownloadResult<Blob>> {
export default class BlobDownloadBuilder implements Promise<DownloadResult<Blob>> {
readonly [Symbol.toStringTag]: string = 'BlobDownloadBuilder'
private promise: Promise<DownloadResult<Blob>> | null = null

constructor(
private downloadFn: () => Promise<Response>,
private shouldThrowOnError: boolean
Expand All @@ -16,7 +19,24 @@ export default class BlobDownloadBuilder implements PromiseLike<DownloadResult<B
onfulfilled?: ((value: DownloadResult<Blob>) => TResult1 | PromiseLike<TResult1>) | null,
onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null
): Promise<TResult1 | TResult2> {
return this.execute().then(onfulfilled, onrejected)
return this.getPromise().then(onfulfilled, onrejected)
}

catch<TResult = never>(
onrejected?: ((reason: any) => TResult | PromiseLike<TResult>) | null
): Promise<DownloadResult<Blob> | TResult> {
return this.getPromise().catch(onrejected)
}

finally(onfinally?: (() => void) | null): Promise<DownloadResult<Blob>> {
return this.getPromise().finally(onfinally)
}

private getPromise(): Promise<DownloadResult<Blob>> {
if (!this.promise) {
this.promise = this.execute()
}
return this.promise
}

private async execute(): Promise<DownloadResult<Blob>> {
Expand Down