Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
A new iter_scan method to reuse a borrowed
Row
; a few additional performance improvements.What is the current behavior?
ForeignDataWrapper::iter_scan
requires the implementor to build a Row, which is quite expensive.What is the new behavior?
ForeignDataWrapper::iter_scan_borrowed
takes a mutable ref to a Row owned by the caller; the implementor just needs to populate it.A default implementation is provided that simply delegates to
ForeignDataWrapper::iter_scan
and swaps the returnedRow
.Additional context
On my machine (intel 8700k), in release mode, pg15, with a sample FDW that yields 10M "helloworld" rows, the time taken to execute
SELECT * FROM bench WHERE id < 0
are:debug2!
oniter_scan
: 1565,417 ms (00:01,565)Row
: 1241,977 ms (00:01,242)I've been unable to run the tests on this, the docs seem out of date and
cargo test
fails to compile.