chore: use borrowed row in iter_scan() #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No safety issues pop out for me here, but I think there may be further room for improvement. I'd suggest establishing a benchmark test and iterating over this design further. Happy to assist there. |
|
The byte copy of row is needed anyway, the saved cost is actually the repetitive row creation and data movement from fdw instance to |
olirice
approved these changes
Jan 5, 2023
kamyshdm
pushed a commit
to dymium-io/supabase-wrappers
that referenced
this pull request
Jun 17, 2024
…g-library Tests with react testing library Former-commit-id: f0eb3e59ecd907f31bb5798f5c3bdf5d8f167981 [formerly aff5f9a7c262992e1a0a63fe601b51183bf3b1bc] Former-commit-id: aedad303cad2fdad4e819668ce76cca10dc00fe0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to use borrowed
rowiniter_scan()to improve performance, see #46 .What is the current behavior?
Currently in each call of the
iter_scan()function, an empty new row needs to be created and values are copied over to Postgres, this can be slow when reading large number of rows.What is the new behavior?
The new
iter_scan()function will pass a pre-allocatedrowand FDW can optionally usemem::replace()to directly move data in.Additional context
See more details in #46 .