Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pluggable compute #2230

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Feat/pluggable compute #2230

merged 2 commits into from
Jul 2, 2024

Conversation

kartik4949
Copy link
Collaborator

Description

fix #2228

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

"""

uri: t.Optional[str] = None # None implies local mode
compute_kwargs: t.Dict = dc.field(default_factory=dict)
_path: t.Optional[str] = 'superduperdb.backends.local.compute.LocalComputeBackend'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

:param compute_kwargs: The keyword arguments to pass to the compute service
:param uri: The URI for the compute service.
:param compute_kwargs: The keyword arguments to pass to the compute service.
:param _path: Compute backend path.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use _path instead of path?

@blythed blythed merged commit 8d74d41 into superduper-io:main Jul 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORTABILITY] Make compute pluggable with a configurable class with _path
3 participants