Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the conflict of the same identifier during encoding. #2464

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix the conflict of the same identifier during encoding. #2464

merged 1 commit into from
Sep 23, 2024

Conversation

jieguangzhou
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@jieguangzhou jieguangzhou linked an issue Sep 20, 2024 that may be closed by this pull request
[PRE-RELEASE-0.4] [BUG] During encoding, leaf uses the identifier as the key for _builds, causing conflicts. #2451
Closed
kartik4949
kartik4949 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@kartik4949 kartik4949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but we can add a test!

@jieguangzhou
Copy link
Collaborator Author

I approved, but we can add a test!

Sure, done

@jieguangzhou jieguangzhou merged commit 84d9f1a into superduper-io:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik4949 kartik4949 kartik4949 approved these changes

@blythed blythed Awaiting requested review from blythed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PRE-RELEASE-0.4] [BUG] During encoding, leaf uses the identifier as the key for _builds, causing conflicts.
2 participants
@jieguangzhou @kartik4949