forked from prusa3d/PrusaSlicer
-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[help-needed] MKS TFT thumbnails #3387
Draft
adripo
wants to merge
89
commits into
supermerill:master
Choose a base branch
from
adripo:tft-thumbnails
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix createrelease as the mac arm can't be compiled on github anymore
Added a piece of code into handle_legacy to check for aliases. '.mf3 files won't open 2.4.58.3' supermerill#2939
…one click instead of two (recovering the old behavior).
Mitigation: remove shallow angles that seems to make it appear. As the previous remove_colinear was on a fixed dist (taht became too small on long segments) I created a new one that work from an angle. supermerill#2971
And fix for the visualization of the spiral start.
fix refresh for float/&percent fixed ask_for_refresh() for non-bool supermerill#3175
…CE if the extruder name is blank supermerill#3073
(maybe still some quirks for raft with many extruders).
This was referenced Oct 30, 2022
can you try instead of
to use
|
supermerill
pushed a commit
that referenced
this pull request
Jan 6, 2023
also it seems you didn't pushed a working version, as it doesn't compile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of MKS TFT thumbnails for other printers than Biqu.
I was inspired by this PR ArtificalSUN/MKS-WIFI_PS_uploader#5 but I don't have much experience in c++.
I would like to get some help to convert the logic that can be found here:
https://github.com/Jeredian/mks-wifi-plugin/blob/develop/MKSPreview.py#L21
and here
https://github.com/SH1NZ33/MKS-WIFI_PS_uploader/blob/patch-1/MKS_WIFI_PS_upload.pyw#L31
For the moment I copied the conversion from Biqu.
The sections that need to be checked and edited are:
I can test any file on my FlyingBear 4S.
fix #3064