Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Bump tooling versions, bump go -> v1.23.0 #3258

Merged
merged 11 commits into from
Nov 25, 2024
Merged

[chore] Bump tooling versions, bump go -> v1.23.0 #3258

merged 11 commits into from
Nov 25, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Sep 1, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request bumps the following:

  • go v1.22 -> v1.23
  • golangci-lint v1.57.2 -> v1.62.0 (and gosec linting)
  • alpine v3.19.1 -> v3.20
  • gotosocial-drone-build v0.6.0 -> v0.7.0, which includes:
    • docker buildx v0.11.2 -> v0.16.2
    • goreleaser v1.25.1 -> v2.3.2

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor Author

Looks like a deprecation notice to address in goreleaser:

DEPRECATED: snapshot.name_template should not be used anymore, check https://goreleaser.com/deprecations#snapshotnametemplate for more info

I'll address that tomorrow or so.

@tsmethurst tsmethurst marked this pull request as ready for review September 2, 2024 13:38
@tsmethurst tsmethurst marked this pull request as draft September 2, 2024 13:48
@tsmethurst
Copy link
Contributor Author

tsmethurst commented Sep 2, 2024

Hmm this is now blocked on go-swagger, which gives the following error under go v1.23.0:

panic: WARNING: can't determine refined type any (*types.Alias)

go-swagger/go-swagger#3131

@NyaaaWhatsUpDoc
Copy link
Member

not really sure what we're gonna do about this 🤔

there does seem to be this PR which fixes things, but it depends whether we use type aliases as to whether this change will effect us or not... i might try a build with it and see if it changes anything

@NyaaaWhatsUpDoc
Copy link
Member

okay running go-swagger with go-swagger/go-swagger#3137 doesn't cause any changes with our build. i'm going to make a temporary release for us with this fix so we can at least bump to Go 1.23

@tsmethurst tsmethurst marked this pull request as ready for review November 25, 2024 13:43
@tsmethurst tsmethurst merged commit c454b1b into main Nov 25, 2024
4 checks passed
@tsmethurst tsmethurst deleted the go_123 branch November 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants