-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] bump to Go1.23 #3570
Closed
NyaaaWhatsUpDoc
wants to merge
11
commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:go_123
Closed
[chore] bump to Go1.23 #3570
NyaaaWhatsUpDoc
wants to merge
11
commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:go_123
+27
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
commented
Nov 25, 2024
@@ -5,7 +5,7 @@ | |||
set -eu | |||
|
|||
swagger_cmd() { | |||
go run github.com/go-swagger/go-swagger/cmd/swagger "$@" | |||
go run ./vendor/github.com/go-swagger/go-swagger/cmd/swagger "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always tests swagger using the vendored version
NyaaaWhatsUpDoc
commented
Nov 25, 2024
project_name: gotosocial | ||
version: 2 | ||
|
||
# https://goreleaser.com/customization/hooks/ | ||
before: | ||
hooks: | ||
# generate the swagger.yaml file using go-swagger and bundle it into the assets directory | ||
- swagger generate spec --scan-models --exclude-deps -o web/assets/swagger.yaml | ||
- go run ./vendor/github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps -o web/assets/swagger.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always generates swagger using the vendored version
moved back to the original PR #3258 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a copy of #3258 but rebased on current main and updated to latest golangci-lint version, and with docker image version strings updated to just use the latest minor version of a particular major image version (this ensures we stay up-to-date with bugfixes but without breaking changes).
i made this a separate PR just because i wasn't totally comfortable doing a force push to something that wasn't my PR :p