chore: detect package manager asynchronously

[benmccann]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 263640c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@465

npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@465

commit: 263640c

[manuel3108]

I don't fully understand why this change is necessary. Previously we tried to keep as much code synchronously where possible (at least as I remember). Based on the release notes of package-manager-detector it does not look like the sync methods are being deprecated or something.

But i'm probably missing something here.

[benmccann]

Yeah, sorry, I should have provided a description. It's not necessary at the moment, but we are discussion removing the synchronous APIs in package-manager-detector, so that we don't have to maintain two versions of every method. I wanted to make sure that it wouldn't affect us much and would be easy enough to adjust to if we do so

[benmccann]

There's a PR out now to drop CJS and sync APIs from package-manager-detector, so it'd probably make sense to move forward with this PR

[manuel3108]

Ahhhh, that was the missing clue. In that case, this is perfect.