chore: detect package manager asynchronously

.changeset/quiet-fans-lick.md

@@ -0,0 +1,5 @@
+---
+"sv": patch
+---
+
+chore: detect package manager asynchronously

packages/cli/commands/add/index.ts

@@ -280,7 +280,7 @@ export async function runAddCommand(
 	}
 
 	// prepare official addons
-	let workspace = createWorkspace({ cwd: options.cwd });
+	let workspace = await createWorkspace({ cwd: options.cwd });
 	const addonSetupResults = setupAddons(officialAddons, workspace);
 
 	// prompt which addons to apply
@@ -312,7 +312,7 @@ export async function runAddCommand(
 
 	// add inter-addon dependencies
 	for (const { addon } of selectedAddons) {
-		workspace = createWorkspace(workspace);
+		workspace = await createWorkspace(workspace);
 
 		const setupResult = addonSetupResults[addon.id];
 		const missingDependencies = setupResult.dependsOn.filter(
@@ -464,7 +464,7 @@ export async function runAddCommand(
 	}
 
 	// format modified/created files with prettier (if available)
-	workspace = createWorkspace(workspace);
+	workspace = await createWorkspace(workspace);
 	if (filesToFormat.length > 0 && packageManager && !!workspace.dependencyVersion('prettier')) {
 		const { start, stop } = p.spinner();
 		start('Formatting modified files');

packages/cli/commands/add/workspace.ts

@@ -3,7 +3,7 @@ import path from 'node:path';
 import * as find from 'empathic/find';
 import { common, object, type AstTypes } from '@sveltejs/cli-core/js';
 import { parseScript } from '@sveltejs/cli-core/parsers';
-import { detectSync } from 'package-manager-detector';
+import { detect } from 'package-manager-detector';
 import type { OptionValues, PackageManager, Workspace } from '@sveltejs/cli-core';
 import { TESTING } from '../../utils/env.ts';
 import { commonFilePaths, getPackageJson, readFile } from './utils.ts';
@@ -14,11 +14,11 @@ type CreateWorkspaceOptions = {
 	packageManager?: PackageManager;
 	options?: OptionValues<any>;
 };
-export function createWorkspace({
+export async function createWorkspace({
 	cwd,
 	options = {},
-	packageManager = detectSync({ cwd })?.name ?? getUserAgent() ?? 'npm'
-}: CreateWorkspaceOptions): Workspace<any> {
+	packageManager
+}: CreateWorkspaceOptions): Promise<Workspace<any>> {
 	const resolvedCwd = path.resolve(cwd);
 	const viteConfigPath = path.join(resolvedCwd, commonFilePaths.viteConfigTS);
 	let usesTypescript = fs.existsSync(viteConfigPath);
@@ -53,7 +53,7 @@ export function createWorkspace({
 	return {
 		cwd: resolvedCwd,
 		options,
-		packageManager,
+		packageManager: packageManager ?? (await detect({ cwd }))?.name ?? getUserAgent() ?? 'npm',
 		typescript: usesTypescript,
 		kit: dependencies['@sveltejs/kit'] ? parseKitOptions(resolvedCwd) : undefined,
 		dependencyVersion: (pkg) => dependencies[pkg]

packages/cli/commands/create.ts

@@ -13,7 +13,7 @@ import {
 } from '@sveltejs/create';
 import * as common from '../utils/common.ts';
 import { runAddCommand } from './add/index.ts';
-import { detectSync, resolveCommand, type AgentName } from 'package-manager-detector';
+import { detect, resolveCommand, type AgentName } from 'package-manager-detector';
 import {
 	addPnpmBuildDependendencies,
 	getUserAgent,
@@ -65,7 +65,8 @@ export const create = new Command('create')
 			let i = 1;
 			const initialSteps: string[] = [];
 			const relative = path.relative(process.cwd(), directory);
-			const pm = packageManager ?? detectSync({ cwd: directory })?.name ?? getUserAgent() ?? 'npm';
+			const pm =
+				packageManager ?? (await detect({ cwd: directory }))?.name ?? getUserAgent() ?? 'npm';
 			if (relative !== '') {
 				const pathHasSpaces = relative.includes(' ');
 				initialSteps.push(

packages/cli/lib/install.ts

@@ -34,7 +34,7 @@ export async function installAddon<Addons extends AddonMap>({
 	options,
 	packageManager = 'npm'
 }: InstallOptions<Addons>): Promise<ReturnType<typeof applyAddons>> {
-	const workspace = createWorkspace({ cwd, packageManager });
+	const workspace = await createWorkspace({ cwd, packageManager });
 	const addonSetupResults = setupAddons(Object.values(addons), workspace);
 
 	return await applyAddons({ addons, workspace, options, addonSetupResults });
@@ -62,7 +62,7 @@ export async function applyAddons({
 	const ordered = orderAddons(mapped, addonSetupResults);
 
 	for (const addon of ordered) {
-		workspace = createWorkspace({ ...workspace, options: options[addon.id] });
+		workspace = await createWorkspace({ ...workspace, options: options[addon.id] });
 
 		const { files, pnpmBuildDependencies } = await runAddon({
 			workspace,

packages/cli/utils/package-manager.ts

@@ -8,7 +8,7 @@ import {
 	AGENTS,
 	COMMANDS,
 	constructCommand,
-	detectSync,
+	detect,
 	type AgentName
 } from 'package-manager-detector';
 import { parseJson } from '@sveltejs/cli-core/parsers';
@@ -19,7 +19,7 @@ agentOptions.unshift({ label: 'None', value: undefined });
 
 type PackageManagerOptions = Array<{ value: AgentName | undefined; label: AgentName | 'None' }>;
 export async function packageManagerPrompt(cwd: string): Promise<AgentName | undefined> {
-	const detected = detectSync({ cwd });
+	const detected = await detect({ cwd });
 	const agent = detected?.name ?? getUserAgent();
 
 	const pm = await p.select({